Use preloadData stuff #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vandenman
approved these changes
Sep 27, 2024
| } | ||
| else | ||
| { | ||
| dataset.factors <- .readDataSetToEnd(columns.as.factor = c(variables, splitName)) |
There was a problem hiding this comment.
This works, but wouldn't it make more sense to assume that if preloadData = TRUE then .readDataSetToEnd is a no-op? This could also be
Suggested change
| dataset.factors <- .readDataSetToEnd(columns.as.factor = c(variables, splitName)) | |
| dataset.factors <- dataset | |
| for (var in c(variables, splitName)) | |
| dataset.factors[[var]] <- as.factor(dataset.factors[[var]]) |
although I guess there is no guarantee that this is exactly the same as if you'd read the variables as factor directly (e.g., read facGender as numeric -> all NA -> as.factor -> all NA vs. read facGender as factor -> actual data). Hmm this really shows descriptives needs another rewrite...
There was a problem hiding this comment.
well, if you disable preloading in Description.qml it will go back to the old behaviour anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For jasp-stats/jasp-desktop#5667